Promblem with nwnx_funcs & nwnx_weapons

[scarface]

Hey Acos, I posted these issues on nwnx.org but you don't sem to be very active on there so I'm posting here.

First problem I have with nwnx_funcs is SetMaxHitPoints() doesn't appear to be working.

I've tried to convert (as much as possible) Funky's Legendary Level system to work with nwnx_funcs instead of LetoScript, and zz-dialog (I found many bugs in z-dialog), and also to work with multiple players simultaneously, that part is fine and everything except hitpoints is working.

Snippet:

if (nSelection < 1)
           {
               // if we had chosen a ability, apply it
               if (GetGainsStatOnLevelUp(oPC) == 1)
               {
                   ModifyAbilityScore(oPC, GetLocalInt(oPC, "ability"), 1);
                   SendMessageToPC(oPC, "Adding Ability: " + GetNameOfAbility(GetLocalInt(oPC, "ability")));
               }
               // if we have chosen a fea, apply it
               if (GetGainsFeatOnLevelUp(oPC) == 1)
               {
                   int nFeat = GetLocalInt(oPC, "feat");
                   // check if the feat was an Epic Greater Ability Feat
                   int nAbility = GetAbilityFromGreaterFeat(nFeat);
                   // if it was, then apply the ability
                   if (nAbility >= 0)
                   {
                       SendMessageToPC(oPC, "Increasing Ability For Greater Feat  " + GetNameOfAbility(nAbility));
                       ModifyAbilityScore(oPC, nAbility, 1);
                   }
                   AddKnownFeat (oPC, nFeat);
                   SendMessageToPC(oPC, "Adding Feat: " + GetNameOfFeat(GetLocalInt(oPC, "feat")));
               }
               // apply skills that need to be
               int nSkill;
               int nSkillAdd;
               for (nSkill = 0; nSkill < 27; nSkill ++)
               {
                   nSkillAdd = GetLocalInt(oPC, "skill_" + IntToString(nSkill));
                   if (nSkillAdd)
                   {
                       ModifySkillRank (oPC, nSkill, nSkillAdd);
                       SendMessageToPC(oPC, "Adding Skill: +" + IntToString(nSkillAdd) + " " + GetNameOfSkill(nSkill));
                   }
               }
               // set hitpoints
               SetMaxHitPoints (oPC, GetMaxHitPoints(oPC) + GetHitPointsGainedOnLevelUp(oPC));
               SendMessageToPC(oPC, "Hitpoints Gained: " + IntToString(GetHitPointsGainedOnLevelUp(oPC)));
               // set saves if necessary
               if (GetGainsSavesOnLevelUp(oPC) == 1)
               {
                   ModifySavingThrowBonus(oPC, SAVING_THROW_FORT, 1);
                   ModifySavingThrowBonus(oPC, SAVING_THROW_REFLEX, 1);
                   ModifySavingThrowBonus(oPC, SAVING_THROW_WILL, 1);
                   SendMessageToPC(oPC, "+1 To All Saving Throws Gained");
               }
               // get and set new level
               int nLevel = CheckLegendaryLevel(oPC);
               SetPCLootable (oPC, ++nLevel);
               ApplyEffectToObject(DURATION_TYPE_INSTANT, EffectVisualEffect(VFX_IMP_LIGHTNING_M), oPC);

               // end the dialog
               dlgEndDialog();
               AssignCommand(oPC, ClearAllActions());
           }

The result I get in the chat log is "Hitpoints Gained: 14", but no hitpoints are applied, every other stat, feat skill is applied just fine though.

My second issue is with nwnx_weapons.

I use the exact switchs that you have posted to modify Devistating Critical vs PCs giving x1 to crit (which works great), but it also gives x1 crit to mobs which is undesired.

Snippet:

SetWeaponOption(NWNX_WEAPONS_OPT_DEVCRIT_DISABLE_PC, TRUE);
   SetWeaponOption(NWNX_WEAPONS_OPT_DEVCRIT_MULT_BONUS, 1);
   SetWeaponOption(NWNX_WEAPONS_OPT_DEVCRIT_MULT_STACK, TRUE);
   SetWeaponOption(NWNX_WEAPONS_OPT_OVERCRIT_RANGE_BONUS, 1);

Great work on the plugins Acos, we use them for many scripts which work flawlessly, these are the only issues we current have.

[FunkySwerve]

As for the hit point function, use this:


                nHP = GetHitPointsGainedOnLevelUp(oPC);//calcualate hit point gain
                nLevel = GetLootable(oPC);
                //sLeto += AddHitPoints(nHP, nLevel);
                sLeto = "Hitpoints: " + IntToString(nHP) + ";";
                nHP += GetMaxHitPointsByLevel(oPC, nLevel-39);
                SetMaxHitPointsByLevel(oPC, nLevel-39, nHP);


Not sure what the issue is with mobs getting the extra mults.

Were the bugs you found in HGLL's version of Z-Dialogue, or pspeed's? I had to fix a few things when I added it, with his help, but I don't think he ever upped the fixes to his vault version. If they were in the HGLL version, what were they?

Funky

[scarface]

Mar 11, 2009 16:14:55 GMT FunkySwerve said:

As for the hit point function, use this:


                nHP = GetHitPointsGainedOnLevelUp(oPC);//calcualate hit point gain
                nLevel = GetLootable(oPC);
                //sLeto += AddHitPoints(nHP, nLevel);
                sLeto = "Hitpoints: " + IntToString(nHP) + ";";
                nHP += GetMaxHitPointsByLevel(oPC, nLevel-39);
                SetMaxHitPointsByLevel(oPC, nLevel-39, nHP);


Not sure what the issue is with mobs getting the extra mults.

Were the bugs you found in HGLL's version of Z-Dialogue, or pspeed's? I had to fix a few things when I added it, with his help, but I don't think he ever upped the fixes to his vault version. If they were in the HGLL version, what were they?

Funky

Cheers Funky, I'll try your snippet.

The z-dialog system works perfectly for your legendary system (and many of systems we use), but whenever I tried to translate it over, I had issues, and I had a few issues with the system itself for a few of our conversarion scripts but since converting over, such as no automated "next" path on larger conversation scripts not being displayed, and some other issues.

zz-dialog worked for me, I can't guarantee it's better for everyone.

The issue with Dev Crit still stands, hope to hear from you or Acos with a solution.

Cheers.

[Acaos]

I'll put the dev crit issue on the todo list for NWNX.

SetMaxHitPoints() only works for monsters. As Funky says, you must use SetMaxHitPointsByLevel() for PCs.

Acaos

[scarface]

Mar 12, 2009 4:59:41 GMT Acaos said:

I'll put the dev crit issue on the todo list for NWNX.

SetMaxHitPoints() only works for monsters. As Funky says, you must use SetMaxHitPointsByLevel() for PCs.

Acaos

Cheers buddy.